Bug 158714

Summary: [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, enrica, simon.fraser, thorton, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
enrica: review+
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2016-06-13 17:31:07 PDT
[iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
Attachments
Patch (16.06 KB, patch)
2016-06-13 17:44 PDT, Simon Fraser (smfr) 		enrica: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (622.21 KB, application/zip)
2016-06-13 18:52 PDT, Build Bot 		no flags
Details
Patch (16.56 KB, patch)
2016-06-14 14:59 PDT, Simon Fraser (smfr) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (747.52 KB, application/zip)
2016-06-14 16:29 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-06-13 17:44:39 PDT
Created attachment 281218 [details] Patch
Build Bot
Comment 2 2016-06-13 18:52:25 PDT
Comment on attachment 281218 [details] Patch Attachment 281218 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1497400 New failing tests: fast/forms/ios/accessory-bar-navigation.html
Build Bot
Comment 3 2016-06-13 18:52:28 PDT
Created attachment 281225 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Simon Fraser (smfr)
Comment 4 2016-06-14 14:59:51 PDT
Created attachment 281284 [details] Patch
Build Bot
Comment 5 2016-06-14 16:29:47 PDT
Comment on attachment 281284 [details] Patch Attachment 281284 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1502871 New failing tests: fast/forms/ios/accessory-bar-navigation.html
Build Bot
Comment 6 2016-06-14 16:29:50 PDT
Created attachment 281296 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Simon Fraser (smfr)
Comment 7 2016-06-15 09:30:30 PDT
I don't know why the test fails on the bots, and the lack of logging output makes it hard to debug.
Simon Fraser (smfr)
Comment 8 2016-06-15 15:49:07 PDT
Ah, tests only work with internal bits.
Enrica Casucci
Comment 9 2016-06-15 15:58:17 PDT
Comment on attachment 281218 [details] Patch You added zooming-test-utils.js in the other patch. This is just slightly different in testZoomAfterTap. You should remove it from this patch if you land the previous one first (or viceversa).
Simon Fraser (smfr)
Comment 10 2016-06-15 16:45:18 PDT
https://trac.webkit.org/r202116
Note You need to log in before you can comment on or make changes to this bug.