Summary: | [GTK] Web view is not redrawn when reparented in force compositing mode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, bugs-noreply, commit-queue, gustavo, mcatanzaro, mrobinson, yoon, zan | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 154444 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2016-06-13 04:55:03 PDT
Created attachment 281167 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Does this fix the similar bug that occurs when resizing the window? (In reply to comment #3) > Does this fix the similar bug that occurs when resizing the window? I don't know I haven't noticed that. Do you mean when resizing the window with the threaded compositor or without it but compositing mode forced? (In reply to comment #4) > (In reply to comment #3) > > Does this fix the similar bug that occurs when resizing the window? > > I don't know I haven't noticed that. Do you mean when resizing the window > with the threaded compositor or without it but compositing mode forced? With compositing mode, without threaded compositor... but actually, I can't reproduce it anymore. Let's forget about it for now; maybe it got fixed at some point. Comment on attachment 281167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281167&action=review (I think Zan would be a better reviewer for this.) > Source/WebKit2/ChangeLog:9 > + mode when the view is unrealized, because the native surface handle por compositing is destroyed, but it doesn't for ;) > Source/WebKit2/ChangeLog:12 > + not. The Web process never exits accelerated mode when compositing mode is forzed, but the UI process doesn't forced Created attachment 281337 [details]
Updated patch
Previous patch broke the build with redirected X window disabled because of a wrong ifdef.
Comment on attachment 281337 [details]
Updated patch
LGTM.
Committed r202273: <http://trac.webkit.org/changeset/202273> |