Bug 158670 – Cleanup RenderBlock::removePositionedObjects

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

Modernize it.

[zalan]

Created attachment 281118 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 281118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281118&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2208
> +        // It is parent blocks job to add positioned child to positioned objects list of its containing block

"It is the parent block's job to add the positioned child lot the positioned objects list of its"

> Source/WebCore/rendering/RenderBlock.cpp:2209
> +        // Parent layout needs to be invalidated to ensure this happens.

"The parent's layout needs"

> Source/WebCore/rendering/RenderBlock.cpp:2211
> +        for (;parent && !parent->isRenderBlock(); parent = parent->parent()) { }

I don't find this more readable than the while ().

[zalan]

(In reply to comment #2)
> Comment on attachment 281118 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281118&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:2208
> > +        // It is parent blocks job to add positioned child to positioned objects list of its containing block
> 
> "It is the parent block's job to add the positioned child lot the positioned
> objects list of its"
> 
> > Source/WebCore/rendering/RenderBlock.cpp:2209
> > +        // Parent layout needs to be invalidated to ensure this happens.
> 
> "The parent's layout needs"
Happens when you just copy&paste the rest of the code.

> 
> > Source/WebCore/rendering/RenderBlock.cpp:2211
> > +        for (;parent && !parent->isRenderBlock(); parent = parent->parent()) { }
> 
> I don't find this more readable than the while ().
I started using it after someone pointed it out in one of code reviews. I don't have a strong preference on this though.

[zalan]

Created attachment 281128 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 281128 [details]
Patch

Clearing flags on attachment: 281128

Committed r201985: <http://trac.webkit.org/changeset/201985>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.