Bug 158650

Summary: Fix some text in Air.js/README.md
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
benjamin: review+
Image none

Filip Pizlo
Reported 2016-06-10 18:08:45 PDT
Patch forthcoming.
Attachments
the patch (3.06 KB, patch)
2016-06-10 18:10 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Image (100.81 KB, patch)
2016-06-11 01:41 PDT, Abu Naser Saifullah 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-06-10 18:10:48 PDT
Created attachment 281069 [details] the patch
Benjamin Poulain
Comment 2 2016-06-10 18:13:49 PDT
Comment on attachment 281069 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=281069&action=review > PerformanceTests/Air.js/README.md:12 > +To run Air.js, simply open "Air.js/test.html" in your browser. It will not run > +correctly if your browser is not mostly ES6 compliant. Double negation isn't the easiest thing to read. "It will only run correctly if you browser has decent ES6 support"?
Filip Pizlo
Comment 3 2016-06-10 18:17:49 PDT
(In reply to comment #2) > Comment on attachment 281069 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281069&action=review > > > PerformanceTests/Air.js/README.md:12 > > +To run Air.js, simply open "Air.js/test.html" in your browser. It will not run > > +correctly if your browser is not mostly ES6 compliant. > > Double negation isn't the easiest thing to read. > "It will only run correctly if you browser has decent ES6 support"? Yes, that's better! Thanks!
Filip Pizlo
Comment 4 2016-06-10 18:19:20 PDT
Landed in http://trac.webkit.org/changeset/201959
Abu Naser Saifullah
Comment 5 2016-06-11 01:41:16 PDT
Created attachment 281093 [details] Image
Note You need to log in before you can comment on or make changes to this bug.