Bug 158567

Summary: Add comments to clarify feature enablement
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, commit-queue, darin, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2016-06-09 08:00:05 PDT
Many developers, both experienced and inexperienced, don't understand how we handle feature enablement. Add some comments FeatureList.pm and WebKitFeatures.cmake to clarify the situation. These comments are accurate for all CMake ports; it would be great to add a comment in FeatureList.pm that addresses XCode as well, but it'd be best if someone from Apple would write that.
Attachments
Patch (2.80 KB, patch)
2016-06-09 08:03 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-06-09 08:03:38 PDT
Created attachment 280919 [details] Patch
WebKit Commit Bot
Comment 2 2016-06-09 13:07:51 PDT
Comment on attachment 280919 [details] Patch Clearing flags on attachment: 280919 Committed r201879: <http://trac.webkit.org/changeset/201879>
WebKit Commit Bot
Comment 3 2016-06-09 13:07:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.