[Threaded Compositor] Content and viewport sizes are mixed

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

So, in ThreadedCoordinatedLayerTreeHost we have:

 - sizeDidChange: called when the main frame contents size changes, but that changes also the coordinator size
 - viewportSizeChanged: called when the viewport size changes, but doesn't change the coordinator size

this is very confusing not only because we are mixing both sizes, but also because sizeDidChange is used in all other layer tree host implementations as the viewport size.

[Carlos Garcia Campos]

Created attachment 280916 [details]
Patch

[Zan Dobersek]

Comment on attachment 280916 [details]
Patch

OK if Yoon approves.

[Gwang Yoon Hwang]

Comment on attachment 280916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280916&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:143
> +void ThreadedCoordinatedLayerTreeHost::contentsSizeChanged(const WebCore::IntSize& newSize)

I like this change which makes more clear.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:172
> +void ThreadedCoordinatedLayerTreeHost::sizeDidChange(const WebCore::IntSize& size)

But I think it would be better to use viewportSizeChanged, which provide more clear idea.
In this change, we will send same size to the CompositingCoordinator and Compositor which implies
our contents size and viewport sile will be same all the time.
But it is not true when we are in the fixed layout.

[Carlos Garcia Campos]

(In reply to comment #3)
> Comment on attachment 280916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280916&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:143
> > +void ThreadedCoordinatedLayerTreeHost::contentsSizeChanged(const WebCore::IntSize& newSize)
> 
> I like this change which makes more clear.
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:172
> > +void ThreadedCoordinatedLayerTreeHost::sizeDidChange(const WebCore::IntSize& size)
> 
> But I think it would be better to use viewportSizeChanged, which provide
> more clear idea.
> In this change, we will send same size to the CompositingCoordinator and
> Compositor which implies
> our contents size and viewport sile will be same all the time.
> But it is not true when we are in the fixed layout.

Current code is what is confusing, because it uses a different name than all other LayerTreeHost implementation, and requires to add #ifdefed code to the drawing area code. There's a check to only update the size when the contents size changes in case of fixed layout.

[Carlos Garcia Campos]

Committed r201923: <http://trac.webkit.org/changeset/201923>