Bug 158513

Summary: Web Inspector: DOMTreeOutline selection areas should be created and updated lazily
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 156250    
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2016-06-07 20:13:15 PDT
In ToT, we 1) create a selection area that covers possibly multiple lines of a DOMTreeOutline 2) delete, recreate, and update the selection area's height whenever an attribute is updated (causes a forced layout) 3) update the selection area whenever expanding, collapsing, attaching, detaching, hovering, or selecting a DOM tree element These things are bad. We should only make selection areas if needed to provide a multiline hover effect or current selection.
Attachments
Proposed Fix (17.53 KB, patch)
2016-06-08 13:18 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-06-07 20:15:32 PDT
<rdar://problem/26689646>
Blaze Burg
Comment 2 2016-06-08 13:18:57 PDT
Created attachment 280828 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-06-08 16:02:43 PDT
Comment on attachment 280828 [details] Proposed Fix Clearing flags on attachment: 280828 Committed r201840: <http://trac.webkit.org/changeset/201840>
WebKit Commit Bot
Comment 4 2016-06-08 16:02:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.