|Product:||WebKit||Reporter:||Mark Lam <mark.lam>|
|Severity:||Normal||CC:||benjamin, buildbot, fpizlo, ggaren, keith_miller, msaboff, rniwa, sbarati|
|Version:||WebKit Local Build|
Description Mark Lam 2016-06-07 15:25:37 PDT
Previously, Interpreter::StackFrame (which is used to capture info for Error.stack) eagerly extracts info out of CodeBlock and duplicate the work that CodeBlock does to compute line and column numbers (amongst other things). This patch does away with the eager extraction and only stashes the CodeBlock pointer in the Interpreter::StackFrame. Instead, Interpreter::StackFrame will provide methods for computing the desired values on request later.
Comment 2 Build Bot 2016-06-07 16:26:57 PDT
Comment on attachment 280741 [details] proposed patch. Attachment 280741 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1462327 New failing tests: fast/events/attribute-listener-deletion-crash.html html5lib/generated/run-tests7-write.html html5lib/generated/run-tests1-write.html html5lib/generated/run-tests18-write.html fast/dom/attribute-event-listener-errors.html fast/events/window-onerror-syntax-error-in-attr.html fast/text/text-combine-crash.html
Comment 3 Build Bot 2016-06-07 16:27:02 PDT
Created attachment 280744 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment 4 Mark Lam 2016-06-07 16:29:38 PDT
Comment on attachment 280741 [details] proposed patch. Taking out of review while I look at the failures. Might just need to rebase some tests.
Comment 6 Saam Barati 2016-06-08 12:42:22 PDT
Comment 7 Mark Lam 2016-06-08 12:56:58 PDT