Bug 15847 – Some editing cleanup

• Component: HTML Editing
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

Some minor modifications I wanted to make while studying editing code. Patch forthcoming.

[Alexey Proskuryakov]

Created attachment 17048 [details]
proposed patch

[Alexey Proskuryakov]

Created attachment 17057 [details]
updated patch

Removed a change to m_starting/endingSelection - I realized that m_starting/endingRootEditableElement depended on it. The constructor still looks wrong, but I don't understand the concepts well enough to suggest a fix.

[Alexey Proskuryakov]

Created attachment 17058 [details]
updated patch

Hmm, on the other hand, m_starting/engingRootEditableElement gets immediately overwritten, too.

[Darin Adler]

Comment on attachment 17058 [details]
updated patch

+        return (NSString *)plainText(makeRange(startVisiblePosition, endVisiblePosition).get());

Why is that typecast needed?

r=me

Another kind of editing cleanup we need is to move as much as possible of the Mac-specific editing code in WebHTMLView into Editor and make it platform-independent. There's some truly-platform-specific code there, but there's more code that is there simply for historic reasons.

[Alexey Proskuryakov]

> +        return (NSString *)plainText(makeRange(startVisiblePosition,
> endVisiblePosition).get());
> 
> Why is that typecast needed?

I thought it was needed because the function returned an id - but looks like Objective-C++ somehow guesses that a conversion to NSString * is implied here!

Committed revision 27477.

[Darin Adler]

(In reply to comment #5)
> I thought it was needed because the function returned an id - but looks like
> Objective-C++ somehow guesses that a conversion to NSString * is implied here!

Bizarre!