Summary: | Remove hasStaticPropertyTable, or make it constexpr | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||||||||||||
Component: | Bindings | Assignee: | Gavin Barraclough <barraclough> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | cdumez, ggaren, rniwa | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Gavin Barraclough
2016-06-06 12:08:05 PDT
Created attachment 281119 [details]
Remove hasStaticPropertyTable (part 1: DOM bindings)
Created attachment 281120 [details]
Remove hasStaticPropertyTable (part 2: JSPluginElement)
Created attachment 281121 [details]
Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
Created attachment 281122 [details]
Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage)
Comment on attachment 281121 [details] Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate) Attachment 281121 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1487534 New failing tests: storage/indexeddb/transaction-complete-workers.html Created attachment 281123 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 281124 [details]
Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
Comment on attachment 281119 [details]
Remove hasStaticPropertyTable (part 1: DOM bindings)
R=me
Comment on attachment 281120 [details]
Remove hasStaticPropertyTable (part 2: JSPluginElement)
R=me, I confirmed this is indeed a no-op.
Comment on attachment 281122 [details]
Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage)
R=me, I added those :) Do we still need the hasStaticPropertyTable flag in the bindings?
(In reply to comment #10) > Comment on attachment 281122 [details] > Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage) > > R=me, I added those :) Do we still need the hasStaticPropertyTable flag in > the bindings? No - won't need any more - after I've landed these 4 I'll upload a 5th patch to remove from the bindings. Comment on attachment 281124 [details]
Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
r=me
Part 1: Committed revision 202028. Part 2: Committed revision 202029. Part 3: Committed revision 202030. Part 4: Committed revision 202031. Build fix in r202032. Created attachment 281242 [details]
Remove hasStaticPropertyTable (part 5: done!)
Comment on attachment 281242 [details]
Remove hasStaticPropertyTable (part 5: done!)
R=me
Committed revision 202218. |