Bug 158428

Summary: operationProcessTypeProfilerLogDFG doesn't update topCallFrame
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2016-06-06 11:11:43 PDT 
...
Comment 1 Saam Barati 2016-06-06 11:13:23 PDT 
<rdar://problem/26571493>
Comment 2 Saam Barati 2016-06-06 11:16:22 PDT 
Created attachment 280610 [details]
patch
Comment 3 Mark Lam 2016-06-06 11:17:00 PDT 
Comment on attachment 280610 [details]
patch

r=me
Comment 4 Mark Lam 2016-06-06 11:17:33 PDT 
Comment on attachment 280610 [details]
patch

Any chance you can add a test that catches this issue?
Comment 5 Saam Barati 2016-06-06 11:25:15 PDT 
(In reply to comment #4)
> Comment on attachment 280610 [details]
> patch
> 
> Any chance you can add a test that catches this issue?

I'll try to make one before landing.
Comment 6 Saam Barati 2016-06-07 12:44:08 PDT 
Comment on attachment 280610 [details]
patch

I spent 30 minutes trying to reproduce this but I can't
It's really hart to get this TypeProfilerLog::processLogEntries to call into GC. It can happen, but it's rare.
Comment 7 WebKit Commit Bot 2016-06-07 13:06:29 PDT 
Comment on attachment 280610 [details]
patch

Clearing flags on attachment: 280610

Committed r201768: <http://trac.webkit.org/changeset/201768>
Comment 8 WebKit Commit Bot 2016-06-07 13:06:33 PDT 
All reviewed patches have been landed.  Closing bug.