| Summary: | getUserMedia() exposed, but not functional | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Niels Leenheer (HTML5test) <info> | ||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Major | CC: | ap, commit-queue, daniele.tassone, eric.carlson, nekr.fabula, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Mac | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
(In reply to comment #0) > > This is also a problem for HTML5test.com where Safari currently gets points > for supporting getUserMedia, without actually deserving so. I hope this is > an unfinished implementation that will be ready for the next release of > Safari, but if not, it should not be exposed publicly. Otherwise I'm afraid > I have to put this feature on a blacklist so that HTML5test.com won't show > an inaccurate result. > > The same thing applies to the prefixed webkitGetUserMedia function. Are you testing with a WebKit nightly build, or with Safari Technology Preview? Safari Technical Preview 5 (this issue has been present since Preview 1) Bug is also visible in WebKit Nightly r201698. Created attachment 282457 [details]
Proposed patch.
Attachment 282457 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:41: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:43: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 282457 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=282457&action=review > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:72 > #if ENABLE(MEDIA_STREAM) Maybe this should be #if ENABLE(MEDIA_STREAM) && PLATFORM(COCOA) ? Comment on attachment 282457 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=282457&action=review >> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:72 >> #if ENABLE(MEDIA_STREAM) > > Maybe this should be #if ENABLE(MEDIA_STREAM) && PLATFORM(COCOA) ? Oops. I meant !PLATFORM(COCOA) :) Created attachment 282460 [details]
Patch for landing.
Comment on attachment 282460 [details] Patch for landing. Clearing flags on attachment: 282460 Committed r202704: <http://trac.webkit.org/changeset/202704> navigator.getUserMedia is no longer exposed in Safari Technology Preview 9.
Not originally mentioned in this bug, but the new API for getUserMedia was also exposed in earlier versions. The patch that has landed did not fix that. In fact, navigator.mediaDevices.getUserMedia is still exposed in the latest Technology
Preview.
navigator.mediaDevices.getUserMedia({ audio: true, video: true }).catch(function(e) { console.log(e) });
=> Error: NotAllowedError: DOM Exception 35
> Committed r202704: <http://trac.webkit.org/changeset/202704>
Moving to RESOLVED since this landed.
|
The getUserMedia() function is exposed, but when you try to use it, it just fails and calls the error callback. This breaks feature detection. navigator.getUserMedia({ video: true, audio: true }, function() { console.log('success', arguments) }, function() { console.log('error', arguments) }) => error – Arguments [ Error: NotAllowedError: DOM Exception 35 ] and: !!navigator.getUserMedia => true This is also a problem for HTML5test.com where Safari currently gets points for supporting getUserMedia, without actually deserving so. I hope this is an unfinished implementation that will be ready for the next release of Safari, but if not, it should not be exposed publicly. Otherwise I'm afraid I have to put this feature on a blacklist so that HTML5test.com won't show an inaccurate result. The same thing applies to the prefixed webkitGetUserMedia function.