Bug 158356

Summary: Give RuleFeatures::classesMatchingAncestors some inline capacity.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2016-06-03 14:15:20 PDT
There are about 362K Vector<AtomicStringImpl*> backing stores getting allocated and freed on a run of PLUM, in the RuleFeatures::classesMatchingAncestors vector. Since RuleFeatures is only ever stack-allocated, we can avoid most/all of this by giving it some inline capacity.
Attachments
Patch (1.38 KB, patch)
2016-06-03 14:15 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-06-03 14:15:54 PDT
Created attachment 280463 [details] Patch
WebKit Commit Bot
Comment 2 2016-06-05 08:18:42 PDT
Comment on attachment 280463 [details] Patch Clearing flags on attachment: 280463 Committed r201697: <http://trac.webkit.org/changeset/201697>
WebKit Commit Bot
Comment 3 2016-06-05 08:18:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.