Summary: | Fix the !ENABLE(SHADOW_DOM) && !ENABLE(DETAILS_ELEMENT) build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, kangil.han, ossy | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2016-06-03 08:00:05 PDT
Created attachment 280443 [details]
Patch
Comment on attachment 280443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280443&action=review > Source/WebCore/dom/ContainerNode.cpp:107 > + if (!child.renderer() && !child.isNamedFlowContentNode() && !childIsHTMLSlotElement) I would prefer dropping the && !is<HTMLSlotElement>(child) from this if. > Source/WebCore/dom/ContainerNode.cpp:109 > if (is<Element>(child)) And add a new if() here: #if ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT) if (!is<HTMLSlotElement>(child)) return; #endif I don't know anything about this code base, so I didn't want to change any logic. It's not obvious for me that the change you suggested won't change the behaviour. I don't have time to learn this code base and don't want to land or propose a change I don't understand. If anybody has time and expertise, feel free to fix it. Comment on attachment 280443 [details] Patch Clearing flags on attachment: 280443 Committed r201723: <http://trac.webkit.org/changeset/201723> All reviewed patches have been landed. Closing bug. |