Bug 158336

Summary: Eliminate two large sources of temporary StringImpl objects.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2016-06-02 19:36:35 PDT
We're allocating over 1 million StringImpls on PLUM that we throw away immediately after using them to key into the AtomicString table.
Attachments
Proposed patch (2.47 KB, patch)
2016-06-02 19:37 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-06-02 19:37:57 PDT
Created attachment 280408 [details] Proposed patch
WebKit Commit Bot
Comment 2 2016-06-03 09:41:49 PDT
Comment on attachment 280408 [details] Proposed patch Clearing flags on attachment: 280408 Committed r201645: <http://trac.webkit.org/changeset/201645>
WebKit Commit Bot
Comment 3 2016-06-03 09:41:53 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2016-06-03 19:43:52 PDT
Comment on attachment 280408 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=280408&action=review > Source/JavaScriptCore/ChangeLog:15 > + (JSC::makeIdentifier): Add an overload for string literals so we can stop creating a temporary > + String just for passing to Identifier::fromString(). Why does the const char* version have to create a temporary String?
Note You need to log in before you can comment on or make changes to this bug.