Bug 158310

Summary: Crash under CachedResource::addClientToSet()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Chris Dumez
Reported 2016-06-02 12:20:33 PDT
Crash under CachedResource::addClientToSet(): Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed ↩: 0 WebCore 0x0000000198f95154 WebCore::CachedResource::addClientToSet(WebCore::CachedResourceClient*) + 36 (CachedResource.cpp:450) 1 WebCore 0x0000000198f95104 WebCore::CachedResource::addClient(WebCore::CachedResourceClient*) + 24 (CachedResource.cpp:433) 2 WebCore 0x0000000198f95104 WebCore::CachedResource::addClient(WebCore::CachedResourceClient*) + 24 (CachedResource.cpp:433) 3 WebCore 0x0000000199f01338 WebCore::WebCoreAVFResourceLoader::startLoading() + 280 (WebCoreAVFResourceLoader.mm:77) 4 WebCore 0x0000000199a87b08 WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource(AVAssetResourceLoadingRequest*) + 216 (MediaPlayerPrivateAVFoundationObjC.mm:1803) 5 JavaScriptCore 0x00000001983f7d54 WTF::dispatchFunctionsFromMainThread() + 540 (functional:1817) 6 Foundation 0x0000000194f8c8bc __NSThreadPerformPerform + 340 (NSThread.m:1228) 7 CoreFoundation 0x00000001944d3b88 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24 (CFRunLoop.c:1943) 8 CoreFoundation 0x00000001944d34d0 __CFRunLoopDoSources0 + 524 (CFRunLoop.c:1989) 9 CoreFoundation 0x00000001944d10d0 __CFRunLoopRun + 804 (CFRunLoop.c:2821) 10 CoreFoundation 0x00000001944024b4 CFRunLoopRunSpecific + 292 (CFRunLoop.c:3103) 11 Foundation 0x0000000194e926fc -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 304 (NSRunLoop.m:367) 12 Foundation 0x0000000194ee6dec -[NSRunLoop(NSRunLoop) run] + 88 (NSRunLoop.m:389) 13 libxpc.dylib 0x00000001941b8f08 _xpc_objc_main + 660 (main.m:186) 14 libxpc.dylib 0x00000001941bac00 xpc_main + 200 (init.c:1438) 15 com.apple.WebKit.WebContent 0x00000001000ab5e4 main + 376 (XPCServiceMain.mm:114) 16 libdyld.dylib 0x0000000193fa3600 start + 4
Attachments
Patch (2.72 KB, patch)
2016-06-02 12:29 PDT, Chris Dumez 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-06-02 12:20:57 PDT
<rdar://problem/23643359>
Chris Dumez
Comment 2 2016-06-02 12:29:00 PDT
Created attachment 280348 [details] Patch
Eric Carlson
Comment 3 2016-06-02 13:34:49 PDT
Comment on attachment 280348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280348&action=review > Source/WebCore/ChangeLog:10 > + by CachedResourceLoader::requestMedia() only if the resource is Nit: "only" not needed on this line.
Chris Dumez
Comment 4 2016-06-02 13:36:03 PDT
Committed r201615: <http://trac.webkit.org/changeset/201615>
Note You need to log in before you can comment on or make changes to this bug.