Bug 158260

Summary: Use inline capacity for StylePropertyShorthand Vectors.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing
none
Archive of layout-test-results from webkit-cq-03 for mac-yosemite none

Description Andreas Kling 2016-06-01 07:00:31 PDT 
0.5% of fastMalloc() bytes on PLUM are coming from Vector<StylePropertyShorthand>. We can avoid all of it by using inline capacity.
Comment 1 Andreas Kling 2016-06-01 07:02:58 PDT 
Created attachment 280233 [details]
Patch
Comment 2 Antti Koivisto 2016-06-01 07:12:08 PDT 
Comment on attachment 280233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280233&action=review

> Source/WebCore/css/StylePropertyShorthand.h:64
> +typedef Vector<StylePropertyShorthand, 4> StylePropertyShorthandVector;

I prefer 

using StylePropertyShorthandVector = Vector<StylePropertyShorthand, 4>;
Comment 3 Andreas Kling 2016-06-01 07:29:46 PDT 
Created attachment 280234 [details]
Patch for landing

Ok then, Dr. Cargo Cultington!
Comment 4 WebKit Commit Bot 2016-06-01 09:02:15 PDT 
Comment on attachment 280234 [details]
Patch for landing

Rejecting attachment 280234 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.webkit.org/results/1418562
Comment 5 WebKit Commit Bot 2016-06-01 09:02:17 PDT 
Created attachment 280239 [details]
Archive of layout-test-results from webkit-cq-03 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 WebKit Commit Bot 2016-06-01 11:13:06 PDT 
Comment on attachment 280234 [details]
Patch for landing

Clearing flags on attachment: 280234

Committed r201559: <http://trac.webkit.org/changeset/201559>
Comment 7 WebKit Commit Bot 2016-06-01 11:13:10 PDT 
All reviewed patches have been landed.  Closing bug.