Bug 158257 – [GTK] Media and audio permission request unit tests are timing out

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

/webkit2/WebKitWebView/usermedia-permission-requests:                
** (WebKitWebProcess:35051): WARNING **: PulseAudio: error: Connection refused

** (WebKitWebProcess:35051): WARNING **: PulseAudio: failed to connect to daemon
TEST: WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestUIClient: TIMEOUT


  /webkit2/WebKitWebView/audio-usermedia-permission-request:           
** (WebKitWebProcess:35379): WARNING **: PulseAudio: error: Connection refused

** (WebKitWebProcess:35379): WARNING **: PulseAudio: failed to connect to daemon
TEST: WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestUIClient: TIMEOUT

I don't know if this is something specific to the bots, or that the API is just broken, I never build with that enabled.

[Philippe Normand]

Looks like a bot issue.

[Michael Catanzaro]

/webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is similarly broken. (I wonder if it ever passed on the bots?) I'm marking it against this bug.

[Philippe Normand]

I can't reproduce this. Let's try to unskip and see the the gtk-api EWS likes it or not...

[Philippe Normand]

Oh actually, I can reproduce this!!! Let's debug the fun...

[Philippe Normand]

Created attachment 398738 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Philippe Normand]

Comment on attachment 398738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398738&action=review

> Source/WebKit/ChangeLog:10
> +        (webkit_settings_set_enable_mock_capture_devices): Hack: relax
> +        secure connection requirement when enabling Mock sources.

Carlos, I haven't found a better way to handle this. In the mac port this is exposed as a private setting. Do we have a similar thing?

[Carlos Garcia Campos]

Comment on attachment 398738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398738&action=review

>> Source/WebKit/ChangeLog:10
>> +        secure connection requirement when enabling Mock sources.
> 
> Carlos, I haven't found a better way to handle this. In the mac port this is exposed as a private setting. Do we have a similar thing?

We don't have private settings, but we can add private API to enable/disable an internal setting.

> Tools/ChangeLog:8
> +        Fix getUserMedia glib tests. They require mock media capture devices.

So, do the tests really need to enable mock devices? or what they really need is enable secure connection and we use that setting to get it?

[Philippe Normand]

Created attachment 398841 [details]
Patch

[Philippe Normand]

Comment on attachment 398738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398738&action=review

>> Tools/ChangeLog:8
>> +        Fix getUserMedia glib tests. They require mock media capture devices.
> 
> So, do the tests really need to enable mock devices? or what they really need is enable secure connection and we use that setting to get it?

In the latest patch I disabled mock devices because indeed I thought they were not required, but here I do have a webcam, tests pass. On the EWS bot there's no webcam, tests time out. So I'll re-enable mock devices and see if the bot likes this...

[Philippe Normand]

Created attachment 398856 [details]
Patch

[Philippe Normand]

api-gtk is green, woohoo.

[Carlos Garcia Campos]

Comment on attachment 398856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398856&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2766
> +void webkitWebViewSetMediaCaptureRequiresSecureConnection(WebKitWebView* webView, bool required)

Why don't you add the private API to WebKitSettings directly?

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2772
> +    page.setPreferences(*preferences);

page is only used here you can getPage(webView).setPreferences(*preferences); But why do you need to set the page preferences again here?

[Philippe Normand]

Created attachment 399002 [details]
Patch

[EWS]

Committed r261473: <https://trac.webkit.org/changeset/261473>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399002 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63082298>