Bug 158253

Summary:

Close wptserve response file handles explicitly

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

158137

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2016-06-01 00:14:06 PDT

wptserve is not closing file-served response file handles explicitly.
This may explain https://bugs.webkit.org/show_bug.cgi?id=158137.

Comment 1 youenn fablet 2016-06-01 00:20:04 PDT

Created attachment 280219 [details]
Patch

Comment 2 Alexey Proskuryakov 2016-06-01 08:58:09 PDT

Comment on attachment 280219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280219&action=review

> LayoutTests/imported/w3c/resources/web-platform-tests-modules.json:91
> -        "url": "https://github.com/youennf/wptserve/archive/9c84ebd90130bef40d440981e0f55947418678b3.tar.gz",
> -        "url_subpath": "wptserve-9c84ebd90130bef40d440981e0f55947418678b3"
> +        "url": "https://github.com/youennf/wptserve/archive/fc902e97a21b8470dcdaab8c70691aea1fecbc12.tar.gz",
> +        "url_subpath": "wptserve-fc902e97a21b8470dcdaab8c70691aea1fecbc12"

I don't think that this is the right development model for WebKit.

Comment 3 WebKit Commit Bot 2016-06-01 09:20:42 PDT

Comment on attachment 280219 [details]
Patch

Clearing flags on attachment: 280219

Committed r201555: <http://trac.webkit.org/changeset/201555>

Comment 4 WebKit Commit Bot 2016-06-01 09:20:46 PDT

All reviewed patches have been landed.  Closing bug.