Summary: | REGRESSION(r201363): "40% regression on date-format-xparb" (Requested by keith_miller on #webkit). | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||||||
Component: | New Bugs | Assignee: | WebKit Commit Bot <commit-queue> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | fpizlo, keith_miller | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 158032, 158136 | ||||||||||
Attachments: |
|
Description
WebKit Commit Bot
2016-05-31 15:32:06 PDT
Created attachment 280189 [details] ROLLOUT of r201363 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 280189 [details] ROLLOUT of r201363 Clearing flags on attachment: 280189 Committed r201532: <http://trac.webkit.org/changeset/201532> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 280362 [details]
Patch for landing
Created attachment 280365 [details]
benchmark-results
These results were taken against the pre-rollout build.
The ! for Int16Array-bubble-sort-with-byteLength.js in the benchmark report is noise.
The other !s for string-concat-object.js, string-concat-pair-object.js, and string-cons-tower.js. As well as the non-progression for date-format-xparb.js were due to a small bug and subsequent runs produced the following results:
SunSpider:
date-format-tofte 6.0138+-0.4548 ? 6.2283+-0.3057 ? might be 1.0357x slower
date-format-xparb 6.9422+-0.0539 ^ 4.3854+-0.1459 ^ definitely 1.5830x faster
<arithmetic> 6.4780+-0.2355 ^ 5.3069+-0.1284 ^ definitely 1.2207x faster
Conf#1 Conf#2
LongSpider:
date-format-tofte 483.6457+-8.5849 481.0978+-12.1114
date-format-xparb 1287.4682+-10.3507 ^ 585.5452+-6.1688 ^ definitely 2.1988x faster
<geometric> 789.0906+-8.3229 ^ 530.7351+-4.6472 ^ definitely 1.4868x faster
string-concat-object 1.7230+-0.1710 1.6878+-0.0833 might be 1.0208x faster
string-concat-pair-object 1.6404+-0.0516 ? 1.7815+-0.1776 ? might be 1.0860x slower
string-concat-pair-simple 2.6100+-0.1266 2.5430+-0.0564 might be 1.0264x faster
string-concat-simple 8.2468+-0.5875 ? 8.4598+-1.0827 ? might be 1.0258x slower
string-cons-repeat 5.9652+-0.5156 5.7872+-0.4014 might be 1.0308x faster
string-cons-tower 5.9332+-0.1850 ? 6.1245+-0.6151 ? might be 1.0322x slower
substring-concat-weird 32.2861+-0.5575 31.8450+-0.4954 might be 1.0139x faster
substring-concat 34.4919+-0.0828 ? 35.3392+-1.7407 ? might be 1.0246x slower
<geometric> 6.2710+-0.2199 ? 6.3261+-0.1676 ? might be 1.0088x slower
Comment on attachment 280362 [details] Patch for landing Clearing flags on attachment: 280362 Committed r201617: <http://trac.webkit.org/changeset/201617> All reviewed patches have been landed. Closing bug. |