Bug 158221

Summary: Audit RenderObject casts and fix problems and style issues found
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Archive of layout-test-results from ews113 for mac-yosemite
none
Patch
none
Patch cdumez: review+

Description Darin Adler 2016-05-31 00:07:54 PDT
Audit RenderObject casts and fix problems and style issues found
Comment 1 Darin Adler 2016-05-31 01:12:11 PDT
Created attachment 280123 [details]
Patch
Comment 2 Build Bot 2016-05-31 01:59:36 PDT
Comment on attachment 280123 [details]
Patch

Attachment 280123 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1411374

New failing tests:
printing/page-break-display-none.html
printing/break-display-none.html
Comment 3 Build Bot 2016-05-31 01:59:40 PDT
Created attachment 280127 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-05-31 02:02:58 PDT
Comment on attachment 280123 [details]
Patch

Attachment 280123 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1411385

New failing tests:
printing/page-break-display-none.html
printing/break-display-none.html
Comment 5 Build Bot 2016-05-31 02:03:02 PDT
Created attachment 280128 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-31 02:11:43 PDT
Comment on attachment 280123 [details]
Patch

Attachment 280123 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1411388

New failing tests:
printing/page-break-display-none.html
printing/break-display-none.html
Comment 7 Build Bot 2016-05-31 02:11:47 PDT
Created attachment 280129 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Darin Adler 2016-05-31 09:17:05 PDT
Created attachment 280148 [details]
Patch
Comment 9 Darin Adler 2016-05-31 09:17:32 PDT
Oops, got a null check wrong. Fixed now.
Comment 10 Darin Adler 2016-05-31 09:44:17 PDT
Created attachment 280153 [details]
Patch
Comment 11 Chris Dumez 2016-05-31 16:43:41 PDT
Comment on attachment 280153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280153&action=review

R=me

> Source/WebCore/html/HTMLFieldSetElement.h:75
> +    bool m_isInDocumentDisabledCount { false };

The naming is confusing considering this is a boolean and not an Integer. How about "hasDisabledAttribute" ?

> Source/WebKit2/Shared/WebRenderObject.cpp:116
> +    for (RenderObject* coreChild = renderer->firstChildSlow(); coreChild; coreChild = coreChild->nextSibling())

auto* ?
Comment 12 Darin Adler 2016-06-01 21:00:18 PDT
Committed r201588: <http://trac.webkit.org/changeset/201588>