Summary: | Audit RenderObject casts and fix problems and style issues found | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||
Component: | Layout and Rendering | Assignee: | Darin Adler <darin> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, cdumez, rniwa, simon.fraser | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Darin Adler
2016-05-31 00:07:54 PDT
Created attachment 280123 [details]
Patch
Comment on attachment 280123 [details] Patch Attachment 280123 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1411374 New failing tests: printing/page-break-display-none.html printing/break-display-none.html Created attachment 280127 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 280123 [details] Patch Attachment 280123 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1411385 New failing tests: printing/page-break-display-none.html printing/break-display-none.html Created attachment 280128 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 280123 [details] Patch Attachment 280123 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1411388 New failing tests: printing/page-break-display-none.html printing/break-display-none.html Created attachment 280129 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 280148 [details]
Patch
Oops, got a null check wrong. Fixed now. Created attachment 280153 [details]
Patch
Comment on attachment 280153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280153&action=review R=me > Source/WebCore/html/HTMLFieldSetElement.h:75 > + bool m_isInDocumentDisabledCount { false }; The naming is confusing considering this is a boolean and not an Integer. How about "hasDisabledAttribute" ? > Source/WebKit2/Shared/WebRenderObject.cpp:116 > + for (RenderObject* coreChild = renderer->firstChildSlow(); coreChild; coreChild = coreChild->nextSibling()) auto* ? Committed r201588: <http://trac.webkit.org/changeset/201588> |