Bug 158209

Summary:

[jsc][mips] fix JIT::emit_op_log_shadow_chicken_prologue/_tail

Product:

WebKit

Reporter:

Guillaume Emont <guijemont>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, commit-queue, guijemont, jbriance, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Guillaume Emont 2016-05-30 09:58:28 PDT

Compilation on MIPS is broken because nonArgGPR0 is regT0 there.

I am trying to run tests with a patch that uses regT4 instead to see if it breaks anything.

Comment 1 Guillaume Emont 2016-06-01 09:11:29 PDT

Created attachment 280241 [details]
Patch

Patch fixing the issue. I ran the stress and regression tests and it does not seem to break anything new

Comment 2 Julien Brianceau 2016-06-06 09:57:05 PDT

If it does not break anything, it cannot hurt. LGTM

Comment 3 Mark Lam 2016-06-06 09:58:30 PDT

Comment on attachment 280241 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2016-06-06 10:20:57 PDT

Comment on attachment 280241 [details]
Patch

Clearing flags on attachment: 280241

Committed r201713: <http://trac.webkit.org/changeset/201713>

Comment 5 WebKit Commit Bot 2016-06-06 10:21:01 PDT

All reviewed patches have been landed.  Closing bug.