Bug 15804

Summary: <object> fallback does not work when both URL and MIME type are omitted
Product: WebKit Reporter: Darin Adler <darin>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: mcguire, mitz, shadow2531
Priority: P2 Keywords: InRadar
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch mitz: review+

Description Darin Adler 2007-11-02 14:46:19 PDT 
Simple test cases demonstrate that <object> won't show its fallback content if both the URL and the MIME type are omitted.
Comment 1 Darin Adler 2007-11-02 14:46:48 PDT 
Created attachment 16999 [details]
patch
Comment 2 Darin Adler 2007-11-02 14:47:31 PDT 
<rdar://problem/5530185>
Comment 3 mitz 2007-11-02 15:10:59 PDT 
Comment on attachment 16999 [details]
patch

+        (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
+        callback. Happens back at the top level of the run loop so it doesn't
+        fire deep inside layout. Also wrote this so that it is guaranteed not to
+        reenter and so that it can handle the case where the delegate destroys
+        the world (including this object).

This is good to fix for WebKit's own Null plugin, (you're fixing bug 15405), but other WebKit plugins can still presumably run arbitrary code under attach(), either mutating the DOM or putting up a sheet, which will cause reentry into WebCore.
Comment 4 mitz 2007-11-02 15:33:12 PDT 
Comment on attachment 16999 [details]
patch

r=me. I just need to make sure to follow up on bug 15404 if it gets closed as a result (which it should).
Comment 5 mitz 2007-11-02 15:34:06 PDT 
(In reply to comment #4)
> bug 15404

I mean bug 15405.
Comment 6 Darin Adler 2007-11-02 16:21:13 PDT 
Committed revision 27378.
Comment 7 David Kilzer (:ddkilzer) 2007-11-02 23:37:34 PDT 
*** Bug 7536 has been marked as a duplicate of this bug. ***
Comment 8 David Kilzer (:ddkilzer) 2007-11-02 23:38:38 PDT 
*** Bug 15202 has been marked as a duplicate of this bug. ***