Bug 157986

Summary: Add a few initiator tests to resource timing.
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: achristensen, commit-queue, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=158019
Attachments:
Description Flags
Patch none

Yoav Weiss
Reported 2016-05-23 03:41:29 PDT
Add a few initiator tests to resource timing.
Attachments
Patch (4.94 KB, patch)
2016-05-23 03:43 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2016-05-23 03:43:15 PDT
Created attachment 279559 [details] Patch
Yoav Weiss
Comment 2 2016-05-23 03:47:48 PDT
This adds some tests that make sure initiator info doesn't get overridden when later requests try to store RT info for the same resource. Currently implementation relies on the fact that HashMap avoids adding entries for keys that are already in the map. Is that part of the semantics of HashMap and can be relied on, or is it necessary to add a check before attempts to add initiator info for a resource?
Alex Christensen
Comment 3 2016-05-23 11:15:47 PDT
HashMap::add does nothing if the key is already in the map, even if you're trying to add it with a different value. HashMap::set will overwrite an existing value for the given key. This behavior won't change.
Yoav Weiss
Comment 4 2016-05-23 12:44:12 PDT
(In reply to comment #3) > HashMap::add does nothing if the key is already in the map, even if you're > trying to add it with a different value. HashMap::set will overwrite an > existing value for the given key. This behavior won't change. cool, didn't know that. In that case, no need to add further checks
Yoav Weiss
Comment 5 2016-05-23 23:07:38 PDT
Comment on attachment 279559 [details] Patch Thanks for reviewing! :)
WebKit Commit Bot
Comment 6 2016-05-23 23:28:51 PDT
Comment on attachment 279559 [details] Patch Clearing flags on attachment: 279559 Committed r201323: <http://trac.webkit.org/changeset/201323>
WebKit Commit Bot
Comment 7 2016-05-23 23:28:54 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 8 2016-05-24 12:47:52 PDT
Reverted r201323 for reason: One of the LayoutTests added with this change fails on all platforms. Rolling out until ResourceTiming flakiness fix is landed Committed r201343: <http://trac.webkit.org/changeset/201343>
Note You need to log in before you can comment on or make changes to this bug.