Some applications truncates the last closing parenthesis in perf dashboard URL

• Component: Perf Dashboard
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Some applications such as Mail and Radar truncates the second closing parenthesis
then two closing parentheses appear in a URL. e.g.

http://localhost/v3/#/charts?since=1461206272848&paneList=((102-5010)-(102-4987)-(102-4988)-(102-4989)-(102-4990)-(102-4991)-(102-4992)-(102-4993)-(102-4994)-(102-4995)-(102-4996)-(102-4997)-(102-4998)-(102-4999)-(102-5000)-(102-5001)-(102-5002)-(102-5003)-(102-5004)-(102-5005)-(102-5006)-(102-5007)-(102-5008)-(102-5009))

This makes perf dashboard URL less useful.

[Ryosuke Niwa]

Created attachment 279547 [details]
Fixes the bug

[Daniel Bates]

Comment on attachment 279547 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=279547&action=review

> Websites/perf.webkit.org/ChangeLog:10
> +        parentheses, for example, is just fine in Radar as well as Apple Mail if the URL is short enough. Using other
> +        characters such as ] and } wouldn't work either because they would be %-escaped. At that point, we might as well

How are these URLs getting into Radar and Apple Mail? By a human copying and pasting? The characters in {"]", "}", ")"} are all reserved characters per <https://tools.ietf.org/html/rfc3986> and can appear in a URL. Appendix C of the URI RFC, <https://tools.ietf.org/html/rfc3986>, suggests delimiting a URI by putting it "within double-quotes..., angle brackets..., or just by using whitespace" and states that "these wrappers do not form part of the URI." Can we make use of one of these wrappers? For example, <http://localhost/v3/#/charts?since=1461206272848&paneList=((102-5010)-(102-4987)-(102-4988)-(102-4989)-(102-4990)-(102-4991)-(102-4992)-(102-4993)-(102-4994)-(102-4995)-(102-4996)-(102-4997)-(102-4998)-(102-4999)-(102-5000)-(102-5001)-(102-5002)-(102-5003)-(102-5004)-(102-5005)-(102-5006)-(102-5007)-(102-5008)-(102-5009))>.

[Daniel Bates]

(In reply to comment #2)
 For example,
> <http://localhost/v3/#/charts?since=1461206272848&paneList=((102-5010)-(102-
> 4987)-(102-4988)-(102-4989)-(102-4990)-(102-4991)-(102-4992)-(102-4993)-(102-
> 4994)-(102-4995)-(102-4996)-(102-4997)-(102-4998)-(102-4999)-(102-5000)-(102-
> 5001)-(102-5002)-(102-5003)-(102-5004)-(102-5005)-(102-5006)-(102-5007)-(102-
> 5008)-(102-5009))>.

Bugzilla does not seem to parse a URI within angle brackets correctly. Let's try using double quotes:

"http://localhost/v3/#/charts?since=1461206272848&paneList=((102-5010)-(102-4987)-(102-4988)-(102-4989)-(102-4990)-(102-4991)-(102-4992)-(102-4993)-(102-4994)-(102-4995)-(102-4996)-(102-4997)-(102-4998)-(102-4999)-(102-5000)-(102-5001)-(102-5002)-(102-5003)-(102-5004)-(102-5005)-(102-5006)-(102-5007)-(102-5008)-(102-5009))"

[Daniel Bates]

(In reply to comment #3)
[...]Let's try using double quotes:
> 
> "http://localhost/v3/#/charts?since=1461206272848&paneList=((102-5010)-(102-
> 4987)-(102-4988)-(102-4989)-(102-4990)-(102-4991)-(102-4992)-(102-4993)-(102-
> 4994)-(102-4995)-(102-4996)-(102-4997)-(102-4998)-(102-4999)-(102-5000)-(102-
> 5001)-(102-5002)-(102-5003)-(102-5004)-(102-5005)-(102-5006)-(102-5007)-(102-
> 5008)-(102-5009))"

Bugzilla did not autolinkify this correctly :(

[Ryosuke Niwa]

Huh, bugzilla strips both parentheses :(

[Ryosuke Niwa]

Created attachment 279608 [details]
Improved the fixup

[Ryosuke Niwa]

Comment on attachment 279608 [details]
Improved the fixup

Clearing flags on attachment: 279608

Committed r201307: <http://trac.webkit.org/changeset/201307>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.