Bug 157969 – check-webkit-style gets flags std::literals::chrono_literals as bad naming

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brady Eidson]

check-webkit-style gets flags some std: namespaces as bogus

Example:
https://bugs.webkit.org/show_bug.cgi?id=157948#c6

"std::literals::chrono_literals is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]"

A good rule for our types, but std::literals::chrono_literals is in the stdlib

[Brady Eidson]

For the underscore rule, we just have a whole bunch of one-off exceptions.

I'll add another.

[Brady Eidson]

Created attachment 279538 [details]
Patch WIP

Don't have time to do the ChangeLog dance tonight before bed, but otherwise this patch is probably good to go.

[Brady Eidson]

Created attachment 279542 [details]
Patch

[Alex Christensen]

I'm not sure this will come up often after the latest patch from https://bugs.webkit.org/show_bug.cgi?id=157948 makes there be just one using namespace std::literals::chrono_literals;
Why does std::numeric_limits::... pass the style check?

[Brady Eidson]

(In reply to comment #4)
> I'm not sure this will come up often after the latest patch from
> https://bugs.webkit.org/show_bug.cgi?id=157948 makes there be just one using
> namespace std::literals::chrono_literals;

While strictly true, any patch that would add such a line itself would be wrongly flagged.

> Why does std::numeric_limits::... pass the style check?

It's explicitly exempted in a different section.

[WebKit Commit Bot]

Comment on attachment 279542 [details]
Patch

Clearing flags on attachment: 279542

Committed r201288: <http://trac.webkit.org/changeset/201288>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.