Bug 157965 – Simulator launch fails intermittently due to failure in checking simulator boot status

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

see <rdar://problem/26402404>

e.g.:
CalledProcessError raised: Command '['xcrun', 'simctl', 'spawn', u'C2F98E0E-D6DF-48B1-BA58-B530ABFB7FF7', 'launchctl', 'print', 'system']' returned non-zero exit status -6
Traceback (most recent call last):
  File "~/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 77, in main
    run_details = run(port, options, args, stderr)
  File "~/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 409, in run
    run_details = manager.run(args)
  File "~/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 205, in run
    if not self._set_up_run(tests_to_run):
  File "~/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 179, in _set_up_run
    self._port.setup_test_run()
  File "~/OpenSource/Tools/Scripts/webkitpy/port/ios.py", line 239, in setup_test_run
    Simulator.wait_until_device_is_booted(self.testing_device(i).udid)
  File "~/OpenSource/Tools/Scripts/webkitpy/xcode/simulator.py", line 281, in wait_until_device_is_booted
    state = subprocess.check_output(['xcrun', 'simctl', 'spawn', udid, 'launchctl', 'print', 'system']).strip()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['xcrun', 'simctl', 'spawn', u'C2F98E0E-D6DF-48B1-BA58-B530ABFB7FF7', 'launchctl', 'print', 'system']' returned non-zero exit status -6

[Aakash Jain]

Created attachment 279530 [details]
Proposed patch

[Alexey Proskuryakov]

Comment on attachment 279530 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279530&action=review

> Tools/Scripts/webkitpy/xcode/simulator.py:286
> +                    _log.warn("Error in checking Simulator boot status.")

This message will be fairly confusing in the logs, because it's unclear what the consequence is. I would add "Will retry in 1 second." after this.

[WebKit Commit Bot]

Comment on attachment 279530 [details]
Proposed patch

Clearing flags on attachment: 279530

Committed r201244: <http://trac.webkit.org/changeset/201244>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Aakash Jain]

Created attachment 279570 [details]
Proposed patch for improving log message