Bug 157950

Summary:

Web Inspector: Split console navigation bar doesn't wrap as expected

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Expected	none
[Image] height: 100%	none
Patch	none
[Image] With patch applied	none

Nikita Vasilyev

Reported 2016-05-20 11:49:50 PDT

https://cloudup.com/cguM608RX6x This is a recent regression.

Attachments
[Image] Expected (80.57 KB, image/png) 2016-05-20 12:13 PDT, Nikita Vasilyev	no flags	Details
[Image] height: 100% (148.31 KB, image/png) 2016-05-23 13:09 PDT, Nikita Vasilyev	no flags	Details
Patch (1.26 KB, patch) 2016-05-23 15:23 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With patch applied (91.43 KB, image/png) 2016-05-23 15:23 PDT, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-05-20 11:50:32 PDT

<rdar://problem/26395573>

Timothy Hatcher

Comment 2 2016-05-20 12:08:43 PDT

I don't think we ever handled this well. Ideally the scope bar would collapse into a single item like we use for the sidebar filtering at the top. But that does not support multiple selection like the Console filtering does.

Nikita Vasilyev

Comment 3 2016-05-20 12:13:55 PDT

Created attachment 279494 [details] [Image] Expected (In reply to comment #2) > I don't think we ever handled this well. Ideally the scope bar would > collapse into a single item like we use for the sidebar filtering at the > top. But that does not support multiple selection like the Console filtering > does. This is how it looks in STP.

Timothy Hatcher

Comment 4 2016-05-20 12:23:47 PDT

I think we were just loosing items off the end as they ran out of room. Not really ideal, but not obviously broken like it is right now. My change yesterday might have broken this. http://trac.webkit.org/changeset/201177/trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.css

Nikita Vasilyev

Comment 5 2016-05-20 14:25:44 PDT

(In reply to comment #4) > I think we were just loosing items off the end as they ran out of room. Not > really ideal, but not obviously broken like it is right now. My change > yesterday might have broken this. > > http://trac.webkit.org/changeset/201177/trunk/Source/WebInspectorUI/ > UserInterface/Views/NavigationBar.css Yes, that change broke it. I'm thinking of a better solution.

Timothy Hatcher

Comment 6 2016-05-20 16:48:08 PDT

Does height: 100% work? I tested it but settled on auto for my change. Maybe there is a difference.

Nikita Vasilyev

Comment 7 2016-05-23 13:09:23 PDT

Created attachment 279581 [details] [Image] height: 100% (In reply to comment #6) > Does height: 100% work? I tested it but settled on auto for my change. Maybe > there is a difference. It works fine for the split console, but it has issues elsewhere.

Nikita Vasilyev

Comment 8 2016-05-23 15:23:09 PDT

Created attachment 279590 [details] Patch

Nikita Vasilyev

Comment 9 2016-05-23 15:23:54 PDT

Created attachment 279591 [details] [Image] With patch applied

WebKit Commit Bot

Comment 10 2016-05-23 16:32:06 PDT

Comment on attachment 279590 [details] Patch Clearing flags on attachment: 279590 Committed r201304: <http://trac.webkit.org/changeset/201304>

WebKit Commit Bot

Comment 11 2016-05-23 16:32:10 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 12 2016-05-25 20:30:04 PDT

*** Bug 158102 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.