Bug 157923

Summary:

Web Inspector: Heap Snapshots taken before timeline view has a zero time do not get shown

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-05-19 14:32:51 PDT

* SUMMARY Heap Snapshots taken before timeline view has a zero time do not get shown. * STEPS TO REPRODUCE 1. Inspect this page 2. Show Timelines tab 3. Show JavaScript Allocations Timeline 4. Click "Take Snapshot" button => Heap Snapshot doesn't show up, it should!

Attachments
[PATCH] Proposed Fix (5.21 KB, patch) 2016-05-19 14:41 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-05-19 14:33:47 PDT

<rdar://problem/26377366>

Joseph Pecoraro

Comment 2 2016-05-19 14:41:54 PDT

Created attachment 279435 [details] [PATCH] Proposed Fix

Matt Baker

Comment 3 2016-05-19 14:51:26 PDT

Snapshots taken before the recording starts will have execution stopwatch times which occur before the recording zero time (once the recording starts). How should this be depicted in the UI? If a snapshot is taken before starting a recording, the recording zero time could be set to the snapshot timestamp. This would fix the issue, but create large gaps in the recording (similar to starting/stopping a recording does now).

WebKit Commit Bot

Comment 4 2016-05-19 15:24:13 PDT

Comment on attachment 279435 [details] [PATCH] Proposed Fix Clearing flags on attachment: 279435 Committed r201191: <http://trac.webkit.org/changeset/201191>

WebKit Commit Bot

Comment 5 2016-05-19 15:24:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.