Bug 157918

Summary: REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[HTML] Reduction
none
[Animated GIF] Bug
none
Patch none

Nikita Vasilyev
Reported 2016-05-19 13:29:21 PDT
Created attachment 279424 [details] [HTML] Reduction Steps: 1. Open the attached reduction (index.html) 2. Inspect the black box 3. Click "Right" button Expected: Styles sidebar shows "left: 10px". Actual: Styles sidebar does NOT show "left: 10px". <rdar://problem/25963130>
Attachments
[HTML] Reduction (526 bytes, text/html)
2016-05-19 13:29 PDT, Nikita Vasilyev 		no flags
Details
[Animated GIF] Bug (199.32 KB, image/gif)
2016-05-19 13:33 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.43 KB, patch)
2016-05-19 14:34 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2016-05-19 13:33:12 PDT
Created attachment 279425 [details] [Animated GIF] Bug
Timothy Hatcher
Comment 2 2016-05-19 13:42:34 PDT
The style attribute is also missing from the DOM tree.
Nikita Vasilyev
Comment 3 2016-05-19 14:06:04 PDT
Bisecting showed that it broke in r189392:189393: http://trac.webkit.org/log/trunk/?rev=189392&stop_rev=189393
Timothy Hatcher
Comment 4 2016-05-19 14:07:22 PDT
(In reply to comment #3) > Bisecting showed that it broke in r189392:189393: > http://trac.webkit.org/log/trunk/?rev=189392&stop_rev=189393 How? Those are not Web Inspector patches.
Nikita Vasilyev
Comment 5 2016-05-19 14:08:03 PDT
Correct link: http://trac.webkit.org/log/trunk/?rev=189392&stop_rev=189353
Nikita Vasilyev
Comment 7 2016-05-19 14:31:01 PDT
This regressed in http://trac.webkit.org/changeset/189385/trunk/Source/WebInspectorUI/UserInterface
Nikita Vasilyev
Comment 8 2016-05-19 14:34:58 PDT
Created attachment 279432 [details] Patch
Nikita Vasilyev
Comment 9 2016-05-19 15:08:02 PDT
(In reply to comment #2) > The style attribute is also missing from the DOM tree. My patch fixed that as well.
WebKit Commit Bot
Comment 10 2016-05-19 15:26:16 PDT
Comment on attachment 279432 [details] Patch Clearing flags on attachment: 279432 Committed r201192: <http://trac.webkit.org/changeset/201192>
WebKit Commit Bot
Comment 11 2016-05-19 15:26:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.