Bug 157877

Summary: Analysis task should look for a git commit based on abridged hashes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, rniwa, slewis
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug cdumez: review+

Ryosuke Niwa
Reported 2016-05-18 18:58:42 PDT
Analysis task should be able to find the right commit based on 8-character hash.
Attachments
Fixes the bug (5.28 KB, patch)
2016-05-18 19:08 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-05-18 18:59:18 PDT
<rdar://problem/26254374>
Ryosuke Niwa
Comment 2 2016-05-18 19:08:52 PDT
Created attachment 279336 [details] Fixes the bug
Chris Dumez
Comment 3 2016-05-18 19:10:37 PDT
Comment on attachment 279336 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=279336&action=review r=me with comment. > Websites/perf.webkit.org/public/privileged-api/associate-commit.php:36 > + exit_with_error('AmbigiousRevision', $commit_info); Typo: Ambiguous > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:499 > + if (error == 'AmbigiousRevision') Same typo.
Ryosuke Niwa
Comment 4 2016-05-18 19:38:55 PDT
Committed r201123: <http://trac.webkit.org/changeset/201123>
Note You need to log in before you can comment on or make changes to this bug.