Bug 157866

Summary:

Fix optimization in markAllDescendantsWithFloatsForLayout

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, ryanhaddad, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Patch	zalan: review+

Dave Hyatt

Reported 2016-05-18 15:25:20 PDT

Clean up sibling float dirtying code.

Attachments
Patch (988 bytes, patch) 2016-05-18 15:26 PDT, Dave Hyatt	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (12.02 MB, application/zip) 2016-05-18 16:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (889.72 KB, application/zip) 2016-05-18 16:30 PDT, Build Bot	no flags	Details
Patch (1.17 KB, patch) 2016-05-19 11:34 PDT, Dave Hyatt	zalan: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2016-05-18 15:26:09 PDT

Created attachment 279300 [details] Patch

Build Bot

Comment 2 2016-05-18 16:11:22 PDT

Comment on attachment 279300 [details] Patch Attachment 279300 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1344840 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2016-05-18 16:11:26 PDT

Created attachment 279309 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-05-18 16:30:11 PDT

Comment on attachment 279300 [details] Patch Attachment 279300 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1344870 New failing tests: storage/websql/statement-success-callback-isolated-world.html storage/websql/transaction-success-callback-isolated-world.html storage/websql/close-during-stress-test.html storage/websql/test-authorizer.html

Build Bot

Comment 5 2016-05-18 16:30:16 PDT

Created attachment 279315 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Ryan Haddad

Comment 6 2016-05-18 16:31:38 PDT

(In reply to comment #4) > Comment on attachment 279300 [details] > Patch > > Attachment 279300 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/1344870 > > New failing tests: > storage/websql/statement-success-callback-isolated-world.html > storage/websql/transaction-success-callback-isolated-world.html > storage/websql/close-during-stress-test.html > storage/websql/test-authorizer.html These failures are unrelated and are fixed by <https://trac.webkit.org/changeset/201107>

Dave Hyatt

Comment 7 2016-05-19 11:34:44 PDT

Created attachment 279405 [details] Patch

Dave Hyatt

Comment 8 2016-05-19 14:50:41 PDT

Fixed in r201186.

Note You need to log in before you can comment on or make changes to this bug.