Bug 157862

Summary: Web Inspector: Checkbox disappears when unchecking CSS property with value containing a semicolon
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, buildbot, commit-queue, graouts, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix none

Matt Baker
Reported 2016-05-18 14:53:13 PDT
* SUMMARY Checkbox disappears when unchecking CSS property with value containing a semicolon. The regex used by CSSStyleDeclarationTextEditor to match commented properties fails to match the following forms: content: ";"; background: url(data:image/png;base64,…);
Attachments
[Patch] Proposed Fix (1.94 KB, patch)
2016-05-18 15:00 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-05-18 14:53:30 PDT
<rdar://problem/16214480>
Matt Baker
Comment 2 2016-05-18 15:00:17 PDT
Created attachment 279293 [details] [Patch] Proposed Fix
Build Bot
Comment 3 2016-05-18 16:00:49 PDT
Comment on attachment 279293 [details] [Patch] Proposed Fix Attachment 279293 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1344773 New failing tests: storage/websql/open-database-over-quota.html
WebKit Commit Bot
Comment 4 2016-05-18 16:00:54 PDT
Comment on attachment 279293 [details] [Patch] Proposed Fix Clearing flags on attachment: 279293 Committed r201111: <http://trac.webkit.org/changeset/201111>
WebKit Commit Bot
Comment 5 2016-05-18 16:01:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.