Bug 157860

Summary: Style resolution for explicitly inherited properties is inefficient
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, kling, rniwa, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite none

Description Antti Koivisto 2016-05-18 13:57:13 PDT
We mark the parent style rather than the style that is actually affected by inherited properties. This leads to various inefficiencies including unnecessary style recalcs.
Comment 1 Antti Koivisto 2016-05-18 14:28:59 PDT
Created attachment 279283 [details]
patch
Comment 2 Build Bot 2016-05-18 15:09:34 PDT
Comment on attachment 279283 [details]
patch

Attachment 279283 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1344600

New failing tests:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
Comment 3 Build Bot 2016-05-18 15:09:37 PDT
Created attachment 279296 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-05-18 15:17:52 PDT
Comment on attachment 279283 [details]
patch

Attachment 279283 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1344601

New failing tests:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
Comment 5 Build Bot 2016-05-18 15:17:55 PDT
Created attachment 279297 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-18 15:24:33 PDT
Comment on attachment 279283 [details]
patch

Attachment 279283 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1344605

New failing tests:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
Comment 7 Build Bot 2016-05-18 15:24:44 PDT
Created attachment 279299 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 8 Antti Koivisto 2016-05-18 15:30:05 PDT
Created attachment 279302 [details]
patch
Comment 9 Build Bot 2016-05-18 16:32:59 PDT
Comment on attachment 279302 [details]
patch

Attachment 279302 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1344869

New failing tests:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
Comment 10 Build Bot 2016-05-18 16:33:03 PDT
Created attachment 279317 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 11 Antti Koivisto 2016-05-19 00:13:34 PDT
Created attachment 279367 [details]
patch
Comment 12 Build Bot 2016-05-19 00:59:46 PDT
Comment on attachment 279367 [details]
patch

Attachment 279367 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1346853

New failing tests:
storage/websql/database-lock-after-reload.html
Comment 13 Build Bot 2016-05-19 00:59:49 PDT
Created attachment 279372 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 14 Antti Koivisto 2016-05-19 06:25:31 PDT
https://trac.webkit.org/r201159