Bug 157854

Summary:

Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, graouts, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
For Landing	none

Blaze Burg

Reported 2016-05-18 12:02:51 PDT

This is kind of a layering violation and it should be entirely handled by models. Then we could make sure the same breakpoint disabling behaviors occurs for tests.

Attachments
Proposed Fix (9.43 KB, patch) 2016-05-18 12:07 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (11.78 MB, application/zip) 2016-05-18 12:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (11.82 MB, application/zip) 2016-05-18 12:47 PDT, Build Bot	no flags	Details
For Landing (9.32 KB, patch) 2016-05-18 13:04 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-05-18 12:04:56 PDT

<rdar://problem/26350487>

Blaze Burg

Comment 2 2016-05-18 12:07:51 PDT

Created attachment 279269 [details] Proposed Fix

Build Bot

Comment 3 2016-05-18 12:41:50 PDT

Comment on attachment 279269 [details] Proposed Fix Attachment 279269 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1343994 New failing tests: inspector/timeline/recording-start-stop-timestamps.html

Build Bot

Comment 4 2016-05-18 12:41:55 PDT

Created attachment 279272 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-05-18 12:47:30 PDT

Comment on attachment 279269 [details] Proposed Fix Attachment 279269 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1344008 New failing tests: inspector/timeline/recording-start-stop-timestamps.html

Build Bot

Comment 6 2016-05-18 12:47:33 PDT

Created attachment 279274 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Blaze Burg

Comment 7 2016-05-18 13:04:52 PDT

Created attachment 279277 [details] For Landing Oops, seems like I forgot to remove some debugging code.

WebKit Commit Bot

Comment 8 2016-05-18 14:03:28 PDT

Comment on attachment 279277 [details] For Landing Clearing flags on attachment: 279277 Committed r201099: <http://trac.webkit.org/changeset/201099>

WebKit Commit Bot

Comment 9 2016-05-18 14:03:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.