Bug 157854

Summary:

Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, graouts, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
For Landing	none

Description BJ Burg 2016-05-18 12:02:51 PDT

This is kind of a layering violation and it should be entirely handled by models. Then we could make sure the same breakpoint disabling behaviors occurs for tests.

Comment 1 Radar WebKit Bug Importer 2016-05-18 12:04:56 PDT

<rdar://problem/26350487>

Comment 2 BJ Burg 2016-05-18 12:07:51 PDT

Created attachment 279269 [details]
Proposed Fix

Comment 3 Build Bot 2016-05-18 12:41:50 PDT

Comment on attachment 279269 [details]
Proposed Fix

Attachment 279269 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1343994

New failing tests:
inspector/timeline/recording-start-stop-timestamps.html

Comment 4 Build Bot 2016-05-18 12:41:55 PDT

Created attachment 279272 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 5 Build Bot 2016-05-18 12:47:30 PDT

Comment on attachment 279269 [details]
Proposed Fix

Attachment 279269 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1344008

New failing tests:
inspector/timeline/recording-start-stop-timestamps.html

Comment 6 Build Bot 2016-05-18 12:47:33 PDT

Created attachment 279274 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 7 BJ Burg 2016-05-18 13:04:52 PDT

Created attachment 279277 [details]
For Landing

Oops, seems like I forgot to remove some debugging code.

Comment 8 WebKit Commit Bot 2016-05-18 14:03:28 PDT

Comment on attachment 279277 [details]
For Landing

Clearing flags on attachment: 279277

Committed r201099: <http://trac.webkit.org/changeset/201099>

Comment 9 WebKit Commit Bot 2016-05-18 14:03:33 PDT

All reviewed patches have been landed.  Closing bug.