Bug 157835 – Refactor toJS functions to use toJSNewlyCreated

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

If toJS functions use toJSNewlyCreated, this will allow some code refactoring.

[youenn fablet]

Created attachment 279240 [details]
Patch

[youenn fablet]

Created attachment 279243 [details]
Patch

[Chris Dumez]

Comment on attachment 279243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279243&action=review

r=me with a couple of comments.

> Source/WebCore/bindings/js/JSMediaStreamCapabilitiesCustom.cpp:43
> +        return CREATE_DOM_WRAPPER(globalObject, AllVideoCapabilities, object);

bah, what about the WTFMove() ?

> Source/WebCore/bindings/js/JSMediaStreamCapabilitiesCustom.cpp:44
> +    return CREATE_DOM_WRAPPER(globalObject, AllAudioCapabilities, object);

bah, what about the WTFMove() ?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3449
> +            push(@implContent, "    return createNewWrapper<$className, $implType>(globalObject, WTFMove(impl));\n");

It does not hurt to call this one all the time. Let's just call this one all the time and get rid of the if ($svgPropertyType) check.

[youenn fablet]

Created attachment 279364 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 279364 [details]
Patch for landing

Clearing flags on attachment: 279364

Committed r201129: <http://trac.webkit.org/changeset/201129>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.