Bug 157832 – Make binding DOM constructor use toJSNewlyCreated instead of toJS

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[youenn fablet]

It would be more efficient to use toJSNewlyCreated for objects created in DOM constructors.

[youenn fablet]

Created attachment 279229 [details]
Patch

[Chris Dumez]

Comment on attachment 279229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279229&action=review

r=me, nice!

> Source/WebCore/bindings/js/JSImageDataCustom.cpp:55
> +    return toJSNewlyCreated(state, globalObject, Ref<ImageData>(imageData));

Do we really need the explicit Ref<>()?

> Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:82
> +    return toJSNewlyCreated(state, globalObject, Ref<TextTrackCue>(cue));

Do we really need the explicit Ref<>()?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:477
> +    return 1 if $interface->extendedAttributes->{"Constructor"} or  $interface->extendedAttributes->{"NamedConstructor"};

nit: extra space in there.

[youenn fablet]

> > Source/WebCore/bindings/js/JSImageDataCustom.cpp:55
> > +    return toJSNewlyCreated(state, globalObject, Ref<ImageData>(imageData));
> 
> Do we really need the explicit Ref<>()?

Yes, which is a bit unfortunate.
Otherwise the compiler is not sure which toJSNewlyCreated to pick.

> > Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:82
> > +    return toJSNewlyCreated(state, globalObject, Ref<TextTrackCue>(cue));
> 
> Do we really need the explicit Ref<>()?

Ditto.

> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:477
> > +    return 1 if $interface->extendedAttributes->{"Constructor"} or  $interface->extendedAttributes->{"NamedConstructor"};
> 
> nit: extra space in there.

OK.

[youenn fablet]

Created attachment 279361 [details]
Patch for landing

[youenn fablet]

Created attachment 279363 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 279363 [details]
Patch for landing

Clearing flags on attachment: 279363

Committed r201128: <http://trac.webkit.org/changeset/201128>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.