Summary: | Improve compile-time assertions in is<>() / downcast<>() | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, darin, kling, koivisto, rniwa | ||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=157811 | ||||||||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2016-05-17 15:38:37 PDT
Created attachment 279203 [details]
Patch
Created attachment 279205 [details]
Patch
Created attachment 279209 [details]
Patch
Comment on attachment 279209 [details] Patch Attachment 279209 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1340359 New failing tests: imported/w3c/web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol.html fast/dom/HTMLMeterElement/meter-element-form.html fast/forms/focus-with-display-block.html Created attachment 279211 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Created attachment 279212 [details]
Patch
Comment on attachment 279212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279212&action=review > Source/WebCore/editing/TextIterator.cpp:271 > + if (is<HTMLFormControlElement>(element) || is<HTMLLegendElement>(element) || is<HTMLProgressElement>(element) || element.hasTagName(meterTag)) This is to maintain the previous behavior on iOS where METER_ELEMENT disabled. Comment on attachment 279212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279212&action=review > Source/WebCore/ChangeLog:59 > + (WebCore::Style::SharingResolver::canShareStyleWithElement): Deleted. This is a bogus comment created by the broken change log prepare script. This function wasn’t deleted. > Source/WTF/wtf/Ref.h:197 > +// For TypeCasts. I don’t fully understand this comment. > Source/WTF/wtf/Ref.h:198 > +template <typename ExpectedType, typename ArgType> inline bool is(Ref<ArgType>& source) I think our style is normally to omit the space after "template". >> Source/WebCore/editing/TextIterator.cpp:271 >> + if (is<HTMLFormControlElement>(element) || is<HTMLLegendElement>(element) || is<HTMLProgressElement>(element) || element.hasTagName(meterTag)) > > This is to maintain the previous behavior on iOS where METER_ELEMENT disabled. Seems unimportant to maintain that behavior. Would be nice to come back and fix this. Created attachment 279441 [details]
Patch
Comment on attachment 279441 [details] Patch Rejecting attachment 279441 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -c /Volumes/Data/EWS/WebKit/Source/WebCore/Modules/webaudio/AudioContext.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AudioContext.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityRenderObject.o accessibility/AccessibilityRenderObject.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/1350588 Created attachment 279443 [details]
Patch
Created attachment 279450 [details]
Patch
Created attachment 279452 [details]
Patch
Comment on attachment 279452 [details] Patch Attachment 279452 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1350982 New failing tests: http/tests/media/video-useragent.html Created attachment 279461 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 279452 [details] Patch Clearing flags on attachment: 279452 Committed r201205: <http://trac.webkit.org/changeset/201205> All reviewed patches have been landed. Closing bug. |