Summary: | [GTK] Clean up CursorGtk.cpp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bugs-noreply, commit-queue, mcatanzaro | ||||||||
Priority: | P2 | ||||||||||
Version: | Other | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Michael Catanzaro
2016-05-17 08:07:23 PDT
Created attachment 279124 [details]
Patch
Comment on attachment 279124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279124&action=review > Source/WebCore/platform/gtk/CursorGtk.cpp:49 > +typedef struct { > + const char* name; > + const unsigned char* bits; > + const unsigned char* mask_bits; > + int hot_x; > + int hot_y; > +} CustomCursor; Where is this used? (In reply to comment #2) > Where is this used? Nowhere :) Comment on attachment 279124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279124&action=review > Source/WebCore/platform/gtk/CursorGtk.cpp:73 > - m_platformCursor = adoptGRef(gdk_cursor_new(GDK_CROSS)); > + m_platformCursor = adoptGRef(gdk_cursor_new_from_name(gdk_display_get_default(), "crosshair")); Maybe we can leave the createNamedCursor helper, but receiving a const char* instead and simply calling gdk_cursor_new_from_name for the default display. Hm, forgot about this. It should hopefully fix a strange bug we have where our mouse cursor sometimes turns into a crap X11 fallback cursor when hovering over links in Wayland. It's because we set the cursor to GDK_HAND2, which is not supported anymore. (In reply to comment #2) > Comment on attachment 279124 [details] > Where is this used? I'll delete it, good catch. (In reply to comment #4) > Maybe we can leave the createNamedCursor helper, but receiving a const char* > instead and simply calling gdk_cursor_new_from_name for the default display. OK. Created attachment 286172 [details]
Patch
Created attachment 286173 [details]
Patch
Comment on attachment 286173 [details] Patch Clearing flags on attachment: 286173 Committed r204691: <http://trac.webkit.org/changeset/204691> All reviewed patches have been landed. Closing bug. |