Bug 157778

Summary: Remove WikiMedia site-specific hack
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: NEW    
Severity: Normal CC: joepeck, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review-

Alex Christensen
Reported 2016-05-16 18:05:14 PDT
Remove WikiMedia site-specific hack
Attachments
Patch (5.12 KB, patch)
2016-05-16 18:08 PDT, Alex Christensen 		rniwa: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-05-16 18:08:15 PDT
Created attachment 279078 [details] Patch
Ryosuke Niwa
Comment 2 2016-05-16 21:00:00 PDT
Comment on attachment 279078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279078&action=review This would break old websites with an old version of Mediawikis. In 2012, 47 out of 200 top WikiMedia users are still using the version 1.5 or older according to http://s23.org/wikistats/largest_html.php. We should gather usage data about this before we should remove this site-specific hack. > Source/WebCore/css/CSSParser.cpp:-272 > - , needsSiteSpecificQuirks(document.settings() ? document.settings()->needsSiteSpecificQuirks() : false) This settings is true on Mac Safari.
Alex Christensen
Comment 3 2016-05-16 21:33:49 PDT
(In reply to comment #2) > Comment on attachment 279078 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279078&action=review > > This would break old websites with an old version of Mediawikis. > > In 2012, 47 out of 200 top WikiMedia users are still using the version 1.5 > or older according to http://s23.org/wikistats/largest_html.php. > We should gather usage data about this before we should remove this > site-specific hack. Chromium seems to have removed this. > > > Source/WebCore/css/CSSParser.cpp:-272 > > - , needsSiteSpecificQuirks(document.settings() ? document.settings()->needsSiteSpecificQuirks() : false) > > This settings is true on Mac Safari. Aha! That makes sense.
Note You need to log in before you can comment on or make changes to this bug.