Bug 157740

Summary: Random CachedFont.cpp cleanup
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, japhet, koivisto, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2016-05-16 08:43:30 PDT
Clean up RefPtr misuse in CachedFont.cpp
Attachments
Patch (2.89 KB, patch)
2016-05-16 08:56 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-05-16 08:52:32 PDT
style checker noticed a couple of "misnamed protector refs" in this file. While there's discussion in https://bugs.webkit.org/show_bug.cgi?id=157591 on the future of the style-checker enforcement of the new naming rule, running it against this file pointed to some tiny opportunities for cleanup.
Brady Eidson
Comment 2 2016-05-16 08:56:06 PDT
Created attachment 279019 [details] Patch
WebKit Commit Bot
Comment 3 2016-05-16 10:21:17 PDT
Comment on attachment 279019 [details] Patch Clearing flags on attachment: 279019 Committed r200944: <http://trac.webkit.org/changeset/200944>
WebKit Commit Bot
Comment 4 2016-05-16 10:21:21 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2016-05-23 17:50:38 PDT
Comment on attachment 279019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279019&action=review > Source/WebCore/loader/cache/CachedFont.cpp:116 > + auto buffer = SharedBuffer::adoptVector(convertedFont); > + return createFontCustomPlatformData(*buffer); I’d like this better without a local variable.
Note You need to log in before you can comment on or make changes to this bug.