Bug 157733

Summary: [GTK][CMake] DerivedSources should be compiled with -Wno-unused-parameter
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, darin, mcatanzaro, mrobinson, ossy
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 155047    
Attachments:
Description Flags
Patch ossy: review-, ossy: commit-queue-

Michael Catanzaro
Reported 2016-05-15 17:51:07 PDT
DerivedSources should be compiled with -Wno-unused-parameter, to avoid useless warnings in Geoclue2Interface.c.
Attachments
Patch (1.32 KB, patch)
2016-05-15 18:39 PDT, Michael Catanzaro 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-05-15 18:39:09 PDT
Created attachment 278989 [details] Patch
Darin Adler
Comment 2 2016-05-23 20:54:34 PDT
(In reply to comment #0) > DerivedSources should be compiled with -Wno-unused-parameter, to avoid > useless warnings in Geoclue2Interface.c. We really want to compile all derived sources this way, just because of that one file?
Csaba Osztrogonác
Comment 3 2016-05-24 00:53:30 PDT
Comment on attachment 278989 [details] Patch I haven't seen this warning, maybe geoclue is disabled in my build. But I agree with Darin, we shouldn't disable unused parameter warnings because of one file. I prefer set_source_file_properties() for this problematic generated source.
Michael Catanzaro
Comment 4 2017-07-13 11:42:44 PDT
(In reply to Csaba Osztrogonác from comment #3) > Comment on attachment 278989 [details] > Patch > > I haven't seen this warning, maybe geoclue is disabled in my build. > > But I agree with Darin, we shouldn't disable unused parameter warnings > because of > one file. I prefer set_source_file_properties() for this problematic > generated source. I guess I must have done this at some point in a different bug, because I think I remember fixing it, and it definitely does not occur anymore.
Note You need to log in before you can comment on or make changes to this bug.