Bug 157692

Summary: REGRESSION: Yahoo sports, finance and news pages automatically scroll
Product: WebKit Reporter: James Craig <jcraig>
Component: MediaAssignee: Aaron Chu <aaron_chu>
Status: RESOLVED FIXED    
Severity: Normal CC: aaron_chu, achristensen, commit-queue, dbates, dino
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 153089    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

James Craig
Reported 2016-05-13 16:38:41 PDT
* SUMMARY Yahoo sports pages automatically scroll * STEPS TO REPRODUCE 1. Go to news.yahoo.com, sports.yahoo.com, finance.yahoo.com * RESULTS Actual: Page automatically scrolls. Expected: Pages doesn’t automatically scroll.
Attachments
Patch (4.00 KB, patch)
2016-05-15 23:31 PDT, Aaron Chu 		no flags
DetailsFormatted DiffDiff
Patch (4.42 KB, patch)
2016-05-16 10:16 PDT, Aaron Chu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Craig
Comment 1 2016-05-13 16:39:02 PDT
<rdar://problem/26231897>
Aaron Chu
Comment 2 2016-05-15 23:31:56 PDT
Created attachment 279001 [details] Patch
Antonio Gomes
Comment 3 2016-05-16 06:16:57 PDT
Comment on attachment 279001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279001&action=review > Source/WebCore/ChangeLog:11 > + Added shouldHaveControls() check before showing the showControlsButton. I believe this tells what the patch does (which is also clear from looking at the bug). Best would be describe the bug, why this was triggered, and then your fix. > LayoutTests/media/video-controls-to-not-scroll-page-on-load.html:23 > + result.innerHTML += (document.body.scrollTop <= 0)? `PASS`: `FAILED: ${document.body.scrollTop} > 0, the page scrolled automatically.` Minor: missing ";". Minor2: either pick single or double quotes within your test code (including HTML part) for consistency.
Aaron Chu
Comment 4 2016-05-16 10:16:46 PDT
Created attachment 279022 [details] Patch
WebKit Commit Bot
Comment 5 2016-05-16 16:07:09 PDT
Comment on attachment 279022 [details] Patch Clearing flags on attachment: 279022 Committed r200976: <http://trac.webkit.org/changeset/200976>
WebKit Commit Bot
Comment 6 2016-05-16 16:07:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.