Bug 157660

Summary: [NetworkCache] Avoid having to re-parse URLs after deserializing them
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, cdumez, cgarcia, commit-queue, darin, koivisto, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-05-12 20:27:45 PDT
Avoid having to re-parse URLs after deserializing them. This impacts both our IPC and our disk cache storage code. We currently serialize URLs as Strings, which means that we have the re-parse them upon deserialization.
Attachments
Patch (11.68 KB, patch)
2016-05-12 20:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.85 KB, patch)
2016-05-13 12:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-12 20:35:15 PDT
Created attachment 278807 [details] Patch
Alex Christensen
Comment 2 2016-05-12 21:56:34 PDT
Comment on attachment 278807 [details] Patch One encoder is better than the two we had before. r=me for correctness, but is this really faster? Also, why are all the member variables signed integers? I think they should be unsigned.
Chris Dumez
Comment 3 2016-05-12 22:03:55 PDT
(In reply to comment #2) > Comment on attachment 278807 [details] > Patch > > One encoder is better than the two we had before. r=me for correctness, but > is this really faster? > Also, why are all the member variables signed integers? I think they should > be unsigned. Do you mind if I change the type of those members in a follow up?
Alexey Proskuryakov
Comment 4 2016-05-12 22:50:34 PDT
Comment on attachment 278807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278807&action=review > Source/WebCore/ChangeLog:9 > + Avoid having to re-parse URLs after deserializing them. This impacts > + both our WK2 IPC and our WK2 network cache storage code. Is this good when handling untrusted URLs from WebContent in UI process?
Darin Adler
Comment 5 2016-05-12 23:53:54 PDT
I agree with Alexey that it in theory would be a problem trusting data from the web process. Worth talking over Anders and Sam at some point.
Chris Dumez
Comment 6 2016-05-13 09:09:57 PDT
(In reply to comment #5) > I agree with Alexey that it in theory would be a problem trusting data from > the web process. Worth talking over Anders and Sam at some point. Ok, based on Alexey and Darin's feedback, I think I'll restrict the optimization to the disk cache for now and not the IPC.
Chris Dumez
Comment 7 2016-05-13 12:02:20 PDT
Created attachment 278858 [details] Patch
WebKit Commit Bot
Comment 8 2016-05-13 19:25:31 PDT
Comment on attachment 278858 [details] Patch Clearing flags on attachment: 278858 Committed r200909: <http://trac.webkit.org/changeset/200909>
WebKit Commit Bot
Comment 9 2016-05-13 19:25:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.