Bug 15763

Summary: [GTK] Enter key does not take to the link highlighted.
Product: WebKit Reporter: Naiem <naiem.shaik>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: naiem.shaik
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://altavista.com
Attachments:
Description Flags
Gdk_return was not being handled, so added it alp: review+

Description Naiem 2007-10-30 04:36:52 PDT
Hi,
I am working in linux box and do not have mouse to do selection of links in a webpage.

Prior information : 
I have applied the patch in bug 15653 and made "return true" in ChromeClient::tabsToLinks() to enable the navigation mode using tabs.

When I run the GtkLauncher, test application present in WebkitTools/Gtklauncher, following is the issue I have faced.
Using Tab key I can scroll between the links,but "Enter key" does not take to the highlighted link.
Comment 1 Alp Toker 2007-11-18 09:41:43 PST
Yep, this still needs to be implemented, patches welcome. Please don't mark bugs like this as "Major".
Comment 2 Naiem 2007-11-18 20:34:48 PST
Created attachment 17373 [details]
Gdk_return was not being handled, so added it

Gdk_Return key press event was not being handled.
Comment 3 Alp Toker 2007-11-20 13:44:22 PST
Comment on attachment 17373 [details]
Gdk_return was not being handled, so added it

Thanks, please provide a patch and a ChangeLog entry next time.
Comment 4 Alp Toker 2007-11-20 13:48:30 PST
Fixed in r27932. It would be nice to clean up these keycodes with a more formal approach some time.