Summary: | Web Inspector: 11% of time in TimelineRecording spent updating DataGrid that is not visible | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-05-11 22:45:51 PDT
Created attachment 278728 [details]
[Patch] Proposed Fix
Comment on attachment 278728 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278728&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineView.js:312 > + if (WebInspector.timelineManager.isCapturing() && !this.showsLiveRecordingData) The ChangeLog says if the view supports live, but this does !live. Which is right? Comment on attachment 278728 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278728&action=review >> Source/WebInspectorUI/UserInterface/Views/TimelineView.js:312 >> + if (WebInspector.timelineManager.isCapturing() && !this.showsLiveRecordingData) > > The ChangeLog says if the view supports live, but this does !live. Which is right? The ChangeLog is correct. Copy paste error. Created attachment 278736 [details]
[Patch] Proposed Fix
Comment on attachment 278736 [details] [Patch] Proposed Fix Clearing flags on attachment: 278736 Committed r200779: <http://trac.webkit.org/changeset/200779> All reviewed patches have been landed. Closing bug. This is great! But there is still a concern that when a datagrid is showing (say layout and rendering) the datagrid is constantly forcing layouts. I wonder if we can improve _updateVisibleRows to not do as much work when its constraints are not changing. For example the view is not resizing and not scrolling, it should probably not always force a layout. |