Bug 157610

Summary:

Rename all protector variables that should be called `protectedThis`

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

http://bugs.webkit.org/show_bug.cgi?id=157591
https://bugs.webkit.org/show_bug.cgi?id=157591

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2016-05-11 22:23:38 PDT

Rename all protector variables that should be called `protectedThis` Per the new style guideline implemented in https://bugs.webkit.org/show_bug.cgi?id=157591 this is the most straightforward upgrade to existing code, as "protectedThis" protectors are almost impossible to be confused with something that is not a protector object.

Attachments
Patch (148.75 KB, patch) 2016-05-12 06:41 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (159.92 KB, patch) 2016-05-13 10:15 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (161.65 KB, patch) 2016-05-13 10:42 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (165.96 KB, patch) 2016-05-13 11:04 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (170.33 KB, patch) 2016-05-13 11:24 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2016-05-12 06:41:52 PDT

Created attachment 278732 [details] Patch Not bothering with ChangeLog or running EWS quite yet, as there's still discussion in 157591 as to whether we're going forward with this new style guideline.

Brady Eidson

Comment 2 2016-05-13 10:15:49 PDT

Created attachment 278845 [details] Patch

WebKit Commit Bot

Comment 3 2016-05-13 10:17:51 PDT

Attachment 278845 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 4 2016-05-13 10:42:19 PDT

Created attachment 278849 [details] Patch

WebKit Commit Bot

Comment 5 2016-05-13 10:43:21 PDT

Attachment 278849 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:741: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:777: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:783: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:911: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 6 2016-05-13 11:04:13 PDT

Created attachment 278852 [details] Patch

WebKit Commit Bot

Comment 7 2016-05-13 11:05:33 PDT

Attachment 278852 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:741: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:777: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:783: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:911: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 8 2016-05-13 11:24:22 PDT

Created attachment 278854 [details] Patch

WebKit Commit Bot

Comment 9 2016-05-13 11:27:32 PDT

Attachment 278854 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:741: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:777: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:783: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:911: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 92 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 10 2016-05-13 12:14:10 PDT

This version of the patch should be good - Only MacWK1 EWS hasn't passed yet, and that's because of a problem in the tree unrelated to this patch.

WebKit Commit Bot

Comment 11 2016-05-13 16:41:27 PDT

Comment on attachment 278854 [details] Patch Clearing flags on attachment: 278854 Committed r200895: <http://trac.webkit.org/changeset/200895>

WebKit Commit Bot

Comment 12 2016-05-13 16:41:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.