Bug 157607

Summary:

Web Inspector: 4% of time in TimelineOverviewGraph adding/removing classList styles on TimelineRecordBar

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-05-11 20:36:07 PDT

4% of time in TimelineOverviewGraph on theverge.com is adding/removing classList styles on TimelineRecordBar. We can eliminate a lot of these by just being smarter about only toggling them when they change.

Attachments
[PATCH] Proposed Fix (4.53 KB, patch) 2016-05-11 20:38 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-05-11 20:38:24 PDT

Created attachment 278691 [details] [PATCH] Proposed Fix

Blaze Burg

Comment 2 2016-05-11 21:10:16 PDT

Comment on attachment 278691 [details] [PATCH] Proposed Fix r=me Good catch.

WebKit Commit Bot

Comment 3 2016-05-11 21:32:04 PDT

Comment on attachment 278691 [details] [PATCH] Proposed Fix Clearing flags on attachment: 278691 Committed r200740: <http://trac.webkit.org/changeset/200740>

WebKit Commit Bot

Comment 4 2016-05-11 21:32:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.