Bug 157553 – If previous media session interruptions were prevented, still allow subsequent interruptions to try.

• Component: Media
• Status: RESOLVED FIXED

[Jeremy Jones]

If previous media session interruptions were prevented, still allow subsequent interruptions to try.

[Jeremy Jones]

rdar://problem/25740804

[Jeremy Jones]

Created attachment 278571 [details]
Patch

[Eric Carlson]

Comment on attachment 278571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278571&action=review

> Source/WebCore/ChangeLog:4
> +        If previous media session interruptions were prevented, still allow subsequent interruptions to try.
> +        https://bugs.webkit.org/show_bug.cgi?id=157553

Please include the Radar number as well.

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:102
> +    

Nit: tab be gone.

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:103
> +    if (++m_interruptionCount > 1 && m_interruptionType != NoInterruption)

Have you verified that there are no side effects of allowing all nested interruptions through?

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 278571 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278571&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        If previous media session interruptions were prevented, still allow subsequent interruptions to try.
> > +        https://bugs.webkit.org/show_bug.cgi?id=157553
> 
> Please include the Radar number as well.

Done.

> 
> > Source/WebCore/platform/audio/PlatformMediaSession.cpp:102
> > +    
> 
> Nit: tab be gone.

Done.

> 
> > Source/WebCore/platform/audio/PlatformMediaSession.cpp:103
> > +    if (++m_interruptionCount > 1 && m_interruptionType != NoInterruption)
> 
> Have you verified that there are no side effects of allowing all nested
> interruptions through?

I don't want to allow all nested interruptions. I only want to allow interruptions if the previous interruption was ignored.

We only ignore EnteringBackground for m_isPlayingToWirelessTarget or Picture in Picture. If we receive any of the other interruptions after that, I would want the interruption to succeed even though the app is in the background.

[Jeremy Jones]

Created attachment 278636 [details]
Patch

[Eric Carlson]

(In reply to comment #4)
> (In reply to comment #3)
> > > Source/WebCore/platform/audio/PlatformMediaSession.cpp:103
> > > +    if (++m_interruptionCount > 1 && m_interruptionType != NoInterruption)
> > 
> > Have you verified that there are no side effects of allowing all nested
> > interruptions through?
> 
> I don't want to allow all nested interruptions. I only want to allow
> interruptions if the previous interruption was ignored.
> 
> We only ignore EnteringBackground for m_isPlayingToWirelessTarget or Picture
> in Picture. If we receive any of the other interruptions after that, I would
> want the interruption to succeed even though the app is in the background.

Isn't 'NoInterruption' only set in endInterruption? In any case, this change definitely needs a layout test to verify that nested interruptions of various types behave as expected.

[Jeremy Jones]

Created attachment 282164 [details]
Patch

[Eric Carlson]

Comment on attachment 282164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282164&action=review

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:103
> +    if (++m_interruptionCount > 1 && m_interruptionType != NoInterruption)

A comment about why this works would be helpful.

> LayoutTests/ChangeLog:17
> +        This test is for iPad only, so it must be run manually.

Is "it must be run manually" true?

[Jeremy Jones]

(In reply to comment #8)
> Comment on attachment 282164 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282164&action=review
> 
> > Source/WebCore/platform/audio/PlatformMediaSession.cpp:103
> > +    if (++m_interruptionCount > 1 && m_interruptionType != NoInterruption)
> 
> A comment about why this works would be helpful.

    // When interruptions are overridden, m_interruptionType doesn't get set.
    // Give nested interruptions a chance when the previous interruptions were overridden.

> 
> > LayoutTests/ChangeLog:17
> > +        This test is for iPad only, so it must be run manually.
> 
> Is "it must be run manually" true?

Tests can't specify that they are iPad only.

[Jeremy Jones]

Created attachment 283954 [details]
Patch for landing.

[Jeremy Jones]

Created attachment 283957 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 283957 [details]
Patch for landing.

Clearing flags on attachment: 283957

Committed r203388: <http://trac.webkit.org/changeset/203388>