Bug 157542

Summary: Web Inspector: "Selected Element" is hard to read when searching for "Element"
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
joepeck: review+
[Image] With patch applied
none
Patch
nvasilyev: commit-queue-
Xcode
none
Patch
none
[Image] With patch applied none

Nikita Vasilyev
Reported 2016-05-10 15:34:55 PDT
Created attachment 278540 [details] [Image] Bug Black text on dark blue background is hard to read.
Attachments
[Image] Bug (26.39 KB, image/png)
2016-05-10 15:34 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.53 KB, patch)
2016-05-10 16:03 PDT, Nikita Vasilyev 		joepeck: review+
DetailsFormatted DiffDiff
[Image] With patch applied (26.41 KB, image/png)
2016-05-10 16:04 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.49 KB, patch)
2016-05-10 16:35 PDT, Nikita Vasilyev 		nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Xcode (18.27 KB, image/png)
2016-05-10 16:42 PDT, Timothy Hatcher 		no flags
Details
Patch (3.15 KB, patch)
2016-05-11 13:33 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (118.78 KB, image/png)
2016-05-11 13:33 PDT, Nikita Vasilyev 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-10 15:35:43 PDT
<rdar://problem/26207464>
Nikita Vasilyev
Comment 2 2016-05-10 16:03:22 PDT
Created attachment 278545 [details] Patch
Nikita Vasilyev
Comment 3 2016-05-10 16:04:40 PDT
Created attachment 278546 [details] [Image] With patch applied
Joseph Pecoraro
Comment 4 2016-05-10 16:27:29 PDT
Comment on attachment 278545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278545&action=review r=me > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:202 > +.search-in-progress .console-item:not(.filtered-out-by-search).console-user-command.special-user-log .console-message-text .highlighted { Is ".console-user-command" needed if we have ".special-user-log"?
Nikita Vasilyev
Comment 5 2016-05-10 16:30:10 PDT
(In reply to comment #4) > Comment on attachment 278545 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278545&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:202 > > +.search-in-progress .console-item:not(.filtered-out-by-search).console-user-command.special-user-log .console-message-text .highlighted { > > Is ".console-user-command" needed if we have ".special-user-log"? Possibly not. ConsoleMessageView.css has: .console-user-command.special-user-log > .console-message-text So I based it on that.
Nikita Vasilyev
Comment 6 2016-05-10 16:35:00 PDT
Created attachment 278549 [details] Patch
Timothy Hatcher
Comment 7 2016-05-10 16:42:27 PDT
Comment on attachment 278549 [details] Patch We should consider dropping the yellow when in a selected background like this. See attached for what Xcode does.
Timothy Hatcher
Comment 8 2016-05-10 16:42:49 PDT
Created attachment 278550 [details] Xcode
Timothy Hatcher
Comment 9 2016-05-10 16:44:43 PDT
The open quickly dialog would benefit from that too.
Nikita Vasilyev
Comment 10 2016-05-10 16:45:27 PDT
I agree. Clearing cq+.
Nikita Vasilyev
Comment 11 2016-05-11 13:33:04 PDT
Created attachment 278658 [details] Patch
Nikita Vasilyev
Comment 12 2016-05-11 13:33:36 PDT
Created attachment 278660 [details] [Image] With patch applied
Timothy Hatcher
Comment 13 2016-05-11 14:32:49 PDT
Looks good!
WebKit Commit Bot
Comment 14 2016-05-11 14:54:37 PDT
Comment on attachment 278658 [details] Patch Clearing flags on attachment: 278658 Committed r200709: <http://trac.webkit.org/changeset/200709>
WebKit Commit Bot
Comment 15 2016-05-11 14:54:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.